Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calypso_onboarding_goals_step_added_goals experiment #97203

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Remove calypso_onboarding_goals_step_added_goals experiment #97203

merged 2 commits into from
Dec 8, 2024
+35 −159

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Dec 7, 2024 •
edited
Loading

Proposed Changes

Removes code for assigning experiment participants, and any code that used the old control variant.

  • Removes calypso_onboarding_goals_step_added_goals assignment code
  • Removes code used by the control variant, since it's now dead code

Why are these changes being made?

We're wrapping up the experiment p1733606517185389-slack-C07H21B2W59

We've collected plenty of data on the difference between the two experiences, and having the extra variation is going to add too many permutations to deal with while working on #96905

Testing Instructions

  • Smoke test the site-setup flow. There should be no changes from the existing treatment experience.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@p-jackson
Remove calypso_onboarding_goals_step_added_goals experiment
1a4db29 
Removes code for assigning experiment participants, and any code that
used the old control variant.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-126854
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-126854&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-126854&env=a8c-for-agencies

@p-jackson p-jackson changed the title Remove calypso_onboarding_goals_step_added_goals experiment Remove calypso_onboarding_goals_step_added_goals experiment Dec 7, 2024
@p-jackson p-jackson self-assigned this Dec 7, 2024
@p-jackson p-jackson requested a review from a team December 7, 2024 21:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 7, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 7, 2024 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~24 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-subscriptions        -90 B  (-0.0%)      -24 B  (-0.0%)
entry-stepper              -90 B  (-0.0%)      -24 B  (-0.0%)
entry-main                 -90 B  (-0.0%)      -24 B  (-0.0%)
entry-login                -90 B  (-0.0%)      -24 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

zaguiini
zaguiini approved these changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@zaguiini zaguiini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

client/landing/stepper/declarative-flow/internals/steps-repository/goals/goals.tsx Outdated Show resolved Hide resolved
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/added-goals-test on your sandbox.

@p-jackson p-jackson merged commit 3e0923d into trunk Dec 8, 2024
9 of 11 checks passed
@p-jackson p-jackson deleted the remove/added-goals-test branch December 8, 2024 03:50
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 8, 2024
@p-jackson p-jackson mentioned this pull request Dec 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaguiini zaguiini zaguiini approved these changes

@arthur791004 arthur791004 Awaiting requested review from arthur791004

Assignees

@p-jackson p-jackson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-jackson @matticbot @zaguiini